Repository navigation
fix(net): reuse DPDK handles after pending I/O retires - #32
Merged
Merged
Conversation
Replace cumulative worker-local handle allocation with reusable slots. Pending operations and completion delivery pin each slot until the old socket can no longer be observed, including cancellation and shutdown. Keep transport close immediate and preserve the public socket APIs. Validate with 6 slot lifetime tests, 12 DPDK ring backend scenarios, and 34 existing networking regressions. Additionally pass 31 slot and kernel runtime tests under ASAN/UBSAN. Physical NIC behavior was not exercised.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DPDK socket handles currently increase monotonically per worker, so a long-running worker eventually returns
EMFILEeven when almost all connections have closed. This change recycles closed handle slots once all pending operations and completion callbacks for the old socket have retired.Implementation
Validation
Run from the Bycorf checkout on ARM64 with Clang 18:
Integration
Lavik only needs the Bycorf submodule update; its networking call sites, including
WriteAllandWriteAllV, remain unchanged.Lavik integration: eloqdata/lavik#455. Merge this PR first; refresh Lavik's gitlink to the resulting main-branch commit if its SHA changes.